Fix infinite loop in jsdoc parsing #17420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbuckton
suggested changes
Jul 26, 2017
src/compiler/parser.ts
Outdated
| @@ -1913,6 +1917,16 @@ namespace ts { | |||
| result.end = getNodeEnd(); | |||
| parsingContext = saveParsingContext; | |||
| return result; | |||
|
|
|||
| function checkZeroLengthNode(startPos: number) { | |||
There was a problem hiding this comment.
Does this need to be in its own function?
src/compiler/parser.ts
Outdated
|
|
||
| function checkZeroLengthNode(startPos: number) { | ||
| if (startPos === scanner.getStartPos()) { | ||
| // What we're parsing isn't actually remotely recognizable as a parameter and we've consumed no tokens whatsoever |
There was a problem hiding this comment.
Comment mentions parameters which may be too specific for this context.
sandersn
approved these changes
Jul 26, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've included a test case demonstrating a (behaviorally) similar bug to those fixed in #17354, but in jsdoc. @sandersn and I were talking about how, after looking at it, it was likely we had a bug like this, so I looked into it and found a reproduction.
The fix generalizes the fix applied in #17354, by moving it into
parseDelimitedList.