Generate diagnostics without a leading comma, retain old spaces #17534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weswigham
changed the title
minestarks
reviewed
Jul 31, 2017
scripts/processDiagnosticMessages.ts
Outdated
|
|
||
| return result; | ||
| // Shave trailing comma, then add newline and ending brace | ||
| return result.slice(0, result.length - 1) + '\r\n}'; |
There was a problem hiding this comment.
Could messageTable have zero elements at this point? I think the shaving of the comma would be wrong then.
There was a problem hiding this comment.
Only if we have zero diagnostics. Which we should never have. Or minimally we shouldn't still be generating this file if we do not.
minestarks
approved these changes
Jul 31, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@minestarks This should once more generate valid json, and with the same whitespace it did before; which should help with the diffs.
Fixes a comment on #17463