Skip to content

quickInfo: Don't check for type === undefined, check for any #17815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
2 commits merged into from
Aug 19, 2017
Merged

quickInfo: Don't check for type === undefined, check for any #17815

2 commits merged into from
Aug 19, 2017

Conversation

ghost
Copy link

@ghost ghost commented Aug 15, 2017

Fixes #17683
getTypeAtLocation and getTypeOfSymbolAtLocation don't return undefined on failure, they return the any type.

Fixes:
a0b6d82 
* We still want to do some work even if type is `any`
* Second test for `if (type)` is necessary because it might not have been assigned.
@ghost ghost requested a review from weswigham August 18, 2017 19:48
@ghost ghost merged commit 5e8e735 into master Aug 19, 2017
@ghost ghost deleted the quickInfoTypeError branch August 19, 2017 00:21
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weswigham @msftclas