Skip to content

Allow use before declaration for export= assignments (#17967) #17972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 23, 2017
Merged

Allow use before declaration for export= assignments (#17967) #17972

merged 2 commits into from
Aug 23, 2017

Conversation

weswigham
Copy link
Member

Port to release branch cc @mhegazy

@weswigham weswigham requested a review from mhegazy August 22, 2017 20:50
@mhegazy
Copy link
Contributor

mhegazy commented Aug 22, 2017

mmm. travis not picking this one up. can you add release-2.5 to the list of branches.

mhegazy
mhegazy approved these changes Aug 22, 2017
View reviewed changes
Copy link
Contributor

@mhegazy mhegazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run tests locally before merging

@weswigham
Copy link
Member Author

@mhegazy Cherry-picked the 4fe7fe7 into this PR, which seems to have caught travis's attention.

@weswigham weswigham merged commit 34e4209 into microsoft:release-2.5 Aug 23, 2017
@weswigham weswigham deleted the port-17967 branch August 23, 2017 17:03
@mhegazy
Copy link
Contributor

mhegazy commented Aug 23, 2017

thanks!

@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@mhegazy mhegazy mhegazy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weswigham @mhegazy @msftclas