Change typed array constructor signature #17978
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. |
|
What is the procedure for merging pull requests? |
|
Generally it's better to merge overloads to use union types, but I'm actually not super into doing so when the first parameter has such a drastically different use. I'll let others weigh in. |
mhegazy
suggested changes
Sep 7, 2017
| @@ -1743,9 +1743,8 @@ interface Int8Array { | |||
| } | |||
| interface Int8ArrayConstructor { | |||
| readonly prototype: Int8Array; | |||
| new(length: number): Int8Array; | |||
| new(array: ArrayLike<number>): Int8Array; | |||
There was a problem hiding this comment.
please keep the first overload there, and change the second to be new(arrayOrBuffer: ArrayLike<number> | ArrayBufferLike): Int8Array;
this way it is clearer that it can either be called with a number, or with ArrayLike/ArrayBufferLike
|
I created an updated PR: #18367. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17962.
This PR changes the constructor definitions of the typed arrays to allow for valid code as described in #17962.