Skip to content

Fix issue #16803 Do not report exports error on getters/setters #18031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2017

Conversation

weswigham
Copy link
Member

Fixes #16803

Simply excludes accessors from the declaration count - any location where they may be part of a module's exports would already have a duplicate identifier error reported were they repeated.

@weswigham weswigham requested review from mhegazy and a user August 24, 2017 22:05
@weswigham weswigham merged commit 336df75 into microsoft:master Aug 24, 2017
@weswigham weswigham deleted the fix-16803 branch August 24, 2017 22:53
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants