Properly report external filenames #18456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhegazy
approved these changes
Sep 14, 2017
mhegazy
reviewed
Sep 14, 2017
| @@ -1659,7 +1659,7 @@ namespace ts { | |||
| } | |||
|
|
|||
| export function isRootedDiskPath(path: string) { | |||
| return getRootLength(path) !== 0; | |||
| return path && getRootLength(path) !== 0; | |||
There was a problem hiding this comment.
so why do we have undefined file paths?
There was a problem hiding this comment.
Answers from plugins may include them
There was a problem hiding this comment.
would not that cause issues in other places as well, and should we just prune/sanitize the list first in these cases?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to list external files during project synchronization for VS to realize they're part of a TS project