Re-enable extraction of a single token #18508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we explicitly prevent extraction of empty spans.
|
@amcasey, |
RyanCavanaugh
approved these changes
Sep 15, 2017
ghost
approved these changes
Sep 15, 2017
|
This seems to have broken a test. I'll push a fix shortly. |
Merged
amcasey
added a commit
to amcasey/TypeScript
that referenced
this pull request
Sep 16, 2017
Re-enable extraction of a single token (cherry picked from commit 47b61ac)
amcasey
added a commit
to amcasey/TypeScript
that referenced
this pull request
Sep 18, 2017
Re-enable extraction of a single token (cherry picked from commit 47b61ac)
amcasey
added a commit
to amcasey/TypeScript
that referenced
this pull request
Sep 20, 2017
Re-enable extraction of a single token (cherry picked from commit 47b61ac)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial revert of b533b24. That change's actual goal was to prevent the lightbulb from appearing for empty selections, but we now check that explicitly.