Use find array helper
#18557
Use find array helper
#18557
Conversation
ghost
requested a review
from 
| @@ -909,7 +909,7 @@ namespace ts.refactor.extractMethod { | |||
| } | |||
| } | |||
|
|
|||
| function getStatementsOrClassElements(scope: Scope): ReadonlyArray<Statement> | ReadonlyArray<ClassElement> { | |||
| function getStatementsOrClassElements(scope: Scope): ReadonlyArray<Statement | ClassElement> { | |||
There was a problem hiding this comment.
I don't believe these types are equivalent. Didn't the old version meant that the list was either all statements or all class elements?
There was a problem hiding this comment.
Yes, but we don't need that information and it breaks type inference on find for some reason.
There was a problem hiding this comment.
Personally, I would leave a comment explaining why we're not using the more accurate type.
| return child; | ||
| } | ||
| } | ||
| return find(getStatementsOrClassElements(scope), child => |
There was a problem hiding this comment.
Since this is a simple find loop, I think using a helper makes sense. In general though, in the absence of expression-level breakpoints (and I would be very happy to learn that these exist), loops are much easier to debug.
There was a problem hiding this comment.
I think node.js recently started supporting column breakpoints -- should be in chrome too.
Just simplifying a method.