Add 'indexOfNode' and use it in cases which may handle long lists. #18635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * For example, searching for a `SourceFile` in a `SourceFile[]` wouldn't work. | ||
| */ | ||
| export function indexOfNode(nodeArray: ReadonlyArray<Node>, node: Node) { | ||
| return binarySearch(nodeArray, node, compareNodePos); |
There was a problem hiding this comment.
One place this wouldn't work is with synthesized nodes. Not sure if those cases can pop up where it's been used so far.
ghost
merged commit
ghost
pushed a commit
that referenced
this pull request
Sep 22, 2017
* Avoid calling `indexOf` when checking array element types * Add 'indexOfNode' and use it in cases which may handle long lists. (#18635) * Fix bug where contextual type was not reused if undefined
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might be overkill but worth just sending a PR.