Remove unnecessary *OrUndefined calls #18889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
amcasey
reviewed
Oct 2, 2017
| @@ -469,7 +469,7 @@ namespace ts.refactor.extractSymbol { | |||
| * depending on what's in the extracted body. | |||
| */ | |||
| function collectEnclosingScopes(range: TargetRange): Scope[] | undefined { | |||
| let current: Node = isReadonlyArray(range.range) ? firstOrUndefined(range.range) : range.range; | |||
| let current: Node = isReadonlyArray(range.range) ? range.range[0] : range.range; | |||
There was a problem hiding this comment.
I would be tempted to add (and call) a first helper for symmetry.
amcasey
approved these changes
Oct 2, 2017
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rangearray should be non-empty; we are treating accesses tofirstOrUndefinedandlastOrUndefinedas certainly defined, so it makes sense to just userange[0]andlast(range).