Skip to content

Conversation

weswigham
Copy link
Member

The new class error was printing the incorrect type in its second type position on the first line (as the format of the message had been changed), and I didn't notice it before merging (since so many of the tests affected in our unittest suite have similar types as member types and base types in those positions). I went to go accept the RWC baselines for the new errors and noticed my error. 😨

@weswigham weswigham requested review from sandersn and mhegazy January 10, 2018 19:24
@weswigham weswigham merged commit ee87cf4 into microsoft:master Jan 10, 2018
@weswigham weswigham deleted the print-correct-type-in-new-error branch January 10, 2018 19:41
@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants