Skip to content

Fix #21089: Do not infer from numeric index signature in Object.values and Object.entries #21129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 17, 2018
Merged

Fix #21089: Do not infer from numeric index signature in Object.values and Object.entries #21129

merged 2 commits into from
Jan 17, 2018

Conversation

mhegazy
Copy link
Contributor

@mhegazy mhegazy commented Jan 10, 2018

Fixes #21089

DanielRosenwasser
DanielRosenwasser requested changes Jan 10, 2018
View reviewed changes
Copy link
Member

@DanielRosenwasser DanielRosenwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test?

@mhegazy mhegazy merged commit b0d7d5a into master Jan 17, 2018
@mhegazy mhegazy deleted the objectEntriesAndValues branch January 17, 2018 22:16
@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhegazy @DanielRosenwasser