Move createTextChange to services/utilities.ts #21416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from
src/services/utilities.ts
Outdated
| export function createTextChange(span: TextSpan, newText: string): TextChange; | ||
| export function createTextChange(start: number, length: number, newText: string): TextChange; | ||
| export function createTextChange(arg0: number | TextSpan, arg1: string | number, newText?: string): TextChange { | ||
| return typeof arg0 === "number" ? createTextChange(createTextSpan(arg0, arg1 as number), newText!) : { span: arg0, newText: arg1 as string }; |
There was a problem hiding this comment.
why not have two separate functions instead of overload ? seems like the typeof check is unnecessary?
sheetalkamat
approved these changes
Jan 25, 2018
amcasey
approved these changes
Jan 26, 2018
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed in #21413 that this function could be useful elsewhere, like
createTextSpanis.