completions: Add assertions that symbols are defined #21764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
defined_symbols
branch
from
cb9f8b8 to
ad97244
Compare
mhegazy
reviewed
Feb 8, 2018
src/compiler/core.ts
Outdated
| return value; | ||
| } | ||
|
|
||
| export function assertEachDefined<T, A extends ReadonlyArray<T>>(value: A): A { |
There was a problem hiding this comment.
Add a required message tag here as well.. it will be much simpler to understand what is going on with a message
mhegazy
approved these changes
Feb 8, 2018
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20787 -- the error was that one of the symbols in
completionDatawas undefined, so had to go over every place we add symbols and assert that it's defined. (Did not add an assert if we're accessing properties on the symbol anyway, which would crash before pushing the symbol.)Also fixes #20563 which was due to
symbolsitself being undefined.