Fix jake lint
#21925
Closed
Fix jake lint
#21925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...by partially reverting d0ab164, which seems to have prevented jake from waiting for the output of linting. Mitigate the issue that that change was trying to mitigate (warning that scripts/generateLocalizedDiagnosticMessages.ts does not exist) by introducing a superfluous wildcard into the filter. TODO: follow up with tslint to figure out why an existing file is reported as not existing.
|
FYI @TravCav |
mhegazy
approved these changes
Feb 13, 2018
mhegazy
reviewed
Feb 13, 2018
| const files = fileMatcher | ||
| ? `src/**/${fileMatcher}` | ||
| : `Gulpfile.ts scripts/generateLocalizedDiagnosticMessages.ts "scripts/tslint/**/*.ts" "src/**/*.ts" --exclude "src/lib/*.d.ts"`; | ||
| : "Gulpfile.ts 'scripts/*generateLocalizedDiagnosticMessages.ts' 'scripts/tslint/**/*.ts' 'src/**/*.ts' --exclude 'src/lib/*.d.ts'"; |
There was a problem hiding this comment.
the string literal did not cause any issues right?
There was a problem hiding this comment.
The type of quotes seemed to matter. In any case, I thought it would be easiest to just revert to a known state and then apply a new workaround.
|
Recalling in favor of deeper fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...by partially reverting d0ab164, which seems to have prevented jake from waiting for the output of linting.
Mitigate the issue that that change was trying to mitigate (warning that scripts/generateLocalizedDiagnosticMessages.ts does not exist) by introducing a superfluous wildcard into the filter.
TODO: follow up with tslint to figure out why an existing file is reported as not existing.