Skip to content

Update user tests for new jsdoc fixes #22582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2018
Merged

Update user tests for new jsdoc fixes #22582

merged 1 commit into from
Mar 14, 2018

Conversation

sandersn
Copy link
Member

From #22510 and #22514, which remove lots of bogus @param errors and add lots of Object is possibly undefined errors, respectively. Looks like overall 400 fewer errors.

There are quite a few effects of the correct addition of undefined to types based on postfix= in jsdoc, actually.

@sandersn
Update user tests for new jsdoc fixes
7e16772 
From #22510 and #22514, which remove lots of bogus `@param` errors and
add lots of `Object is possibly undefined` errors, respectively.

There are quite a few effects of the correct addition of undefined to
types based on postfix= in jsdoc, actually.
@sandersn sandersn requested a review from weswigham March 14, 2018 21:29
weswigham
weswigham approved these changes Mar 14, 2018
View reviewed changes
Copy link
Member

@weswigham weswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lodash seems to play fast and loose with allowing undefined and using it in places that don't. 😄

@sandersn
Copy link
Member Author

Yep. JSDoc!

@sandersn sandersn merged commit 0d684b5 into master Mar 14, 2018
@sandersn sandersn deleted the update-user-tests-032018 branch March 14, 2018 21:40
@microsoft microsoft locked and limited conversation to collaborators Jul 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@weswigham weswigham weswigham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sandersn @weswigham