textChanges: Clean up *Options interfaces #22813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
ghost
requested a review
from 
amcasey
reviewed
Mar 26, 2018
|
|
||
| // TODO (https://github.com/Microsoft/TypeScript/issues/21246): default should probably be useNonAdjustedPositions | ||
| public replaceRange(sourceFile: SourceFile, range: TextRange, newNode: Node, options: ChangeNodeOptions = {}) { | ||
| public replaceRange(sourceFile: SourceFile, range: TextRange, newNode: Node, options: InsertNodeOptions = {}) { |
There was a problem hiding this comment.
As before, I personally find it strange to change parameter types of some, but not all, members of this family of functions.
There was a problem hiding this comment.
interface ChangeNodeOptions extends ConfigurableStartEnd, InsertNodeOptions {}. ConfigurableStartEnd determines how the start and end positions of the node parameter are adjusted. This function doesn't take a node as a parameter, so those options would be unused.
| } | ||
|
|
||
| export interface ChangeNodeOptions extends ConfigurableStartEnd, InsertNodeOptions { | ||
| readonly useIndentationFromFile?: boolean; |
There was a problem hiding this comment.
I gather this property was unused?
amcasey
approved these changes
Mar 26, 2018
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConfigurableStartEndafter the change is created, so those just need to storeInsertNodeOptions.useIndentationFromFileoption was never used.