Skip to content

Improve string literal completions from a signature #23062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Apr 2, 2018
Merged

Improve string literal completions from a signature #23062

1 commit merged into from
Apr 2, 2018

Conversation

ghost
Copy link

@ghost ghost commented Apr 2, 2018

Fixes #23061

  • Don't use a signature when we've already written more arguments than it accepts.
  • Set isNewIdentifierLocation if we see the string type in at least one signature.

@ghost ghost force-pushed the completionForStringLiteralFromSignature branch from 33ca030 to 6225511 Compare April 2, 2018 15:52
@ghost ghost requested review from armanio123 and sheetalkamat April 2, 2018 16:09
@ghost ghost merged commit 8e14ac7 into master Apr 2, 2018
@ghost ghost deleted the completionForStringLiteralFromSignature branch April 2, 2018 20:04
@microsoft microsoft locked and limited conversation to collaborators Jul 25, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@armanio123 armanio123 Awaiting requested review from armanio123

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sheetalkamat