Skip to content

Copy consistient valueDeclarations on union/intersection symbols #23190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 27, 2018
Merged

Copy consistient valueDeclarations on union/intersection symbols #23190

merged 2 commits into from
Apr 27, 2018

Conversation

weswigham
Copy link
Member

We use valueDeclaration for checking if privates align, but it wasn't set on union/intersection symbols, even if all members' symbols came from the same declaration.

Fixes #22845

@weswigham weswigham requested review from sandersn, mhegazy and a user April 5, 2018 23:29
@weswigham weswigham merged commit d5ef117 into microsoft:master Apr 27, 2018
@weswigham weswigham deleted the mixin-conditional-visibility branch April 27, 2018 20:12
@microsoft microsoft locked and limited conversation to collaborators Jul 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sandersn sandersn Awaiting requested review from sandersn

1 more reviewer

@mhegazy mhegazy mhegazy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weswigham @mhegazy