patternMatcher: Just return 'undefined' for an invalid pattern #23237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhegazy
reviewed
Apr 6, 2018
| @@ -10,6 +10,7 @@ namespace ts.NavigateTo { | |||
|
|
|||
| export function getNavigateToItems(sourceFiles: ReadonlyArray<SourceFile>, checker: TypeChecker, cancellationToken: CancellationToken, searchValue: string, maxResultCount: number, excludeDtsFiles: boolean): NavigateToItem[] { | |||
There was a problem hiding this comment.
should return ReadonlyArray then.
There was a problem hiding this comment.
This is exposed as a service, so must wait on #16312 to turn these all to ReadonlyArray (e.g. ReadonlyArray<DefinitionInfo>, ReadonlyArray<ReferenceEntry>...)
mhegazy
approved these changes
Apr 6, 2018
ghost
merged commit 
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A PatternMatcher for an invalid pattern will just return
undefinedfor all queries, so we might as well not use it at all.Also,
dotSeparatedSegmentsis guaranteed to have length at least 1 because it comes from.split().