Fix bug: don't insert a semicolon when inserting a FunctionDeclaration #23240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
convertFunctionToEs6ClassNoSemicolon
branch
from
d9e08ea to
162446f
Compare
ghost
changed the title
mhegazy
approved these changes
Apr 9, 2018
|
Please port to release-2.8 as well. |
ghost
pushed a commit
that referenced
this pull request
Apr 9, 2018
ghost
mentioned this pull request
ghost
pushed a commit
that referenced
this pull request
Apr 9, 2018
ghost
pushed a commit
that referenced
this pull request
Apr 9, 2018
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23235
The bug was because we were trying to insert a semicolon after a node we were also deleting.
A better fix might be to use
replaceNodeinstead ofdeleteNodeandinsertNodeAfter, but that seemed to break a few tests. (It also wouldn't work with a variable declaration in a VariableDeclarationList with multiple entries, but I don't think it's too important to support that use case.)