When testing references, also test documentHighlights respects filesToSearch #23306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhegazy
approved these changes
Apr 10, 2018
ghost
force-pushed
the
document_highlights_files
branch
2 times, most recently
from
ad4cae5 to
fb1eb47
Compare
|
@mhegazy Could you review the new change to |
mhegazy
reviewed
Apr 11, 2018
| Debug.assert(program.redirectTargetsSet.has(fileName)); | ||
| const redirectTarget = program.getSourceFile(fileName); | ||
| const redirect = find(sourceFilesToSearch, f => f.redirectInfo && f.redirectInfo.redirectTarget === redirectTarget)!; | ||
| fileName = redirect.fileName; |
There was a problem hiding this comment.
we are not sure this fileName is in the list either.. we should probally assert that it is.
mhegazy
approved these changes
Apr 11, 2018
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23294