Skip to content

Improve performance of duplicate check #23516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Apr 18, 2018
Merged

Improve performance of duplicate check #23516

1 commit merged into from
Apr 18, 2018

Conversation

ghost
Copy link

@ghost ghost commented Apr 18, 2018

Don't loop over the entire array in the inner loop, just the elements past the current one.

@ghost ghost requested review from sheetalkamat and armanio123 April 18, 2018 17:55
@ghost ghost merged commit 0e9b815 into master Apr 18, 2018
@ghost ghost deleted the dup_impl branch April 18, 2018 19:58
@microsoft microsoft locked and limited conversation to collaborators Jul 30, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@armanio123 armanio123 Awaiting requested review from armanio123

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sheetalkamat