Fix #16675: Better error message for dynamic import with ES2015 modules #23957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhegazy
reviewed
May 9, 2018
src/compiler/diagnosticMessages.json
Outdated
| @@ -895,7 +895,7 @@ | |||
| "category": "Error", | |||
| "code": 1322 | |||
| }, | |||
| "Dynamic import cannot be used when targeting ECMAScript 2015 modules.": { | |||
| "Dynamic import cannot be used when targeting ECMAScript 2015 modules. Please use 'esnext' or 'commonjs' as module compiler option.": { | |||
There was a problem hiding this comment.
how about Dynamic import is only supported when '--module' flag is 'commonjs' or esNext`.
|
I agree with the comments and have changed the error message. |
|
thanks! |
|
Thanks for this fantastic project! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16675. Following the suggestions in this ticket this PR improves the error message when users try to use dynamic imports while having ES2015 as module in the compiler options.