Do not emit 'use strict' prologue in .json files with --alwaysStrict #24524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-tarasyuk
force-pushed
the
bug/24514-use-strict-prologue-emitted-in-json-files
branch
from
ccf16e6 to
7ef7f90
Compare
|
Looks good to me, though really I can't help but wonder whether there's a more resilient way for us to have prevented statements from being inserted into the source file. |
sheetalkamat
approved these changes
May 31, 2018
|
When is this PR planned to be released? In the meantime, is there a workaround? |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24514