Ignore trailing comma when resolving signature for quick info #25841
Conversation
|
|
|
sorry for some reason i thought you had test case for signature help and not quickInfo, Can you please add test case for signature help? |
ghost
force-pushed
the
quickInfoSignatureHelpTrailingComma
branch
from
5446836 to
1a62233
Compare
| tags: [{ name: "param", text: "radix The radix" }], | ||
| }); | ||
| verify.signatureHelp( | ||
| { |
There was a problem hiding this comment.
Previously this test was wrong -- the edit.insert call applied to the start of the file, changing the first line to str(2,|function str(n: number): string; and eliminating that overload. The correct behavior still has two overloads, but shows the one with higher arity first.
As for the second test showing {} instead of number, that's because in signature help, we assume a trailing comma indicates trying to write another argument, which means chooseOverload fails and we go to getCandidateForOverloadFailure which doesn't infer type arguments.
Fixes #25807