Use import().T for import completions/fixes of pure types in JS files
#25852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
importCompletions_importType
branch
from
b025f65 to
317a77d
Compare
ghost
force-pushed
the
importCompletions_importType
branch
from
317a77d to
9feb4de
Compare
| function getFixForImport( | ||
| exportInfos: ReadonlyArray<SymbolExportInfo>, | ||
| symbolName: string, | ||
| symbolToken: Node | undefined, | ||
| position: number | undefined, | ||
| program: Program, | ||
| sourceFile: SourceFile, | ||
| host: LanguageServiceHost, | ||
| preferences: UserPreferences, | ||
| ): ReadonlyArray<ImportFix> { | ||
| const checker = program.getTypeChecker(); |
There was a problem hiding this comment.
Why not exit early here when position is undefined ? without doing any of the work.
There was a problem hiding this comment.
We actually might return a result if we don't need to add a qualifier to the use. We would add an import at the top of the file and not need position.
sheetalkamat
approved these changes
Jul 26, 2018
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23407
Note: converted importFixes from passing around
symbolTokentopositionbecause we may get an import completion at a location with no Identifier there yet.