Fixes #26122 - erroneous "TS2350" for js constructors called with incorrect parameters #26124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `resolveCall` does not resolve in `resolveNewExpression`, the error should only be thrown if there is a *defined* signature that is not-void.
ghost
requested a review
from 
jameskeane
changed the title
sandersn
approved these changes
Aug 1, 2018
|
Re switching call to construct signatures: Probably yes, but there's a lot of code that expects constructor functions to have call signatures. It won't be a trivial change, I think. The compiler has supported constructor functions for a long time, but TS support is quite limited so there weren't many places to change until a year or two ago. |
|
@sandersn thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
resolveCalldoes not resolve a signature inresolveNewExpression, the error should only be thrown if there is a defined signature that is not-void.Fixes #26122
Should we consider marking the call signatures of functions with
@constructoras construct signatures (as in PR #25980). It caused a weird bug withtypeFromPropertyAssignment12that is probably worth understanding.