Allow super references to constructor function methods #26482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, they were mistakenly treated as private because of a check that required all super property accesses (like `super.x()`) to be references to a MethodDeclaration or MethodSignature. This change also allows PrototypeProperty special assignment kinds.
ghost
reviewed
Aug 16, 2018
src/compiler/checker.ts
Outdated
| @@ -17866,6 +17866,12 @@ namespace ts { | |||
|
|
|||
| function symbolHasNonMethodDeclaration(symbol: Symbol) { | |||
| return forEachProperty(symbol, prop => { | |||
There was a problem hiding this comment.
Replacing this function body with return !!forEachProperty(symbol, prop => !(prop.flags & SymbolFlags.Method)); seems to pass all tests.
There was a problem hiding this comment.
Nice! That's a much better solution.
ghost
approved these changes
Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, they were mistakenly treated as private because of a check that required all super property accesses (like
super.x()) to be references to a MethodDeclaration or MethodSignature. This change also allows PrototypeProperty special assignment kinds.Fixes #26475