Skip to content

Widen export assignment types so they arent accidentally fresh #27397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2018
Merged

Widen export assignment types so they arent accidentally fresh #27397

merged 1 commit into from
Oct 4, 2018

Conversation

weswigham
Copy link
Member

Fixes #27091

Also use checkExpressionCached instead of checkExpression because export assignments aren't going to be able to be affected by any context and checkExportAssignment is already caching it.

@weswigham weswigham mentioned this pull request Sep 27, 2018
Closed
sandersn
sandersn approved these changes Oct 2, 2018
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IFoo is my favourite kind of foob.

@weswigham weswigham merged commit 10edf6f into microsoft:master Oct 4, 2018
@weswigham weswigham deleted the export-assignment-freshness-stripping branch October 4, 2018 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn sandersn approved these changes

@RyanCavanaugh RyanCavanaugh RyanCavanaugh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weswigham @sandersn @RyanCavanaugh