Use relative module specifiers in error messages if possible #27441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanCavanaugh
requested changes
Oct 1, 2018
src/compiler/types.ts
Outdated
| @@ -3183,6 +3183,8 @@ namespace ts { | |||
| InTypeAlias = 1 << 23, // Writing type in type alias declaration | |||
| InInitialEntityName = 1 << 24, // Set when writing the LHS of an entity name or entity name expression | |||
| InReverseMappedType = 1 << 25, | |||
|
|
|||
| /* @internal */ DoNotIncludeSymbolChain = 1 << 25, // Skip looking up and printing an accessible symbol chain | |||
There was a problem hiding this comment.
This has the same value as the one above it?
|
@RyanCavanaugh wanna update your review? |
RyanCavanaugh
approved these changes
Oct 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25747
We don't create node module specifiers since within the checker during checking because we don't really have access to the FS to do the
fileExistsandreadFilecalls to check if a given possible representation is valid. Naturally, if it seems it's necessary (ie, we dislike./node_modules/foo/barin errors enough) we can rig something up to pass them through from the compiler host.