Do not do any reduction (even if it contains any) to the union type when getting contextual type #28005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen getting contextual type Fixes #27975
weswigham
reviewed
Oct 20, 2018
| removeSubtypes(typeSet); | ||
| break; | ||
| } | ||
| if (typeSet.length === 0) { |
There was a problem hiding this comment.
Shouldn't this branch still be outside the new if (unionReduction !== UnionReduction.None) { check? We can't go making 0-element unions, after all~
There was a problem hiding this comment.
If types = 0 then its never as done by getUnionTypeFromSortedList because we are adding all the types to typeset when there is no reduction (only removing duplicates)
There was a problem hiding this comment.
Hm, I guess so; only the never case can be triggered when there are no reductions going on, and getUnionTypeFromSortedList does have a check for exactly that, so I guess it's fine.
weswigham
approved these changes
Oct 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27975
Thanks @weswigham for point to this.