Skip to content

Conversation

ghost
Copy link

@ghost ghost commented Nov 2, 2018

These outputs are accumulated using flatMap, so the arrays are never written to again. So it's safe to return a ReadonlyArray.

Copy link
Member

@sheetalkamat sheetalkamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Though there are test failures

@ghost ghost merged commit afbf89e into master Nov 2, 2018
@ghost ghost deleted the refactor_readonlyarray branch November 2, 2018 17:07
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant