Better checking of assignment declarations #28387
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, type checking was turned off for all assignment declarations. This is a problem when the declarations are annotated with jsdoc types:
As @DanielRosenwasser points out, this will become more common as people use checkJS more and more.
This PR checks assignment declarations, except for expando initialisers. Expando initialisers are
prototype assignment or module.exports assignment.
It's probably possible to write a reasonable ad-hoc check for expando initalisers too, but they are (I think) least likely to be annotated since it looks weird:
Fixes #27327