Skip to content

Count only unit types when counting overlapping keys #28695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2018
Merged

Count only unit types when counting overlapping keys #28695

merged 1 commit into from
Nov 30, 2018
+9 −9

Conversation

weswigham
Copy link
Member

This way an unconstrained T compared against string | number | symbol no longer chooses string over the last one, symbol, when they all equally do not have overlapping properties.

@DanielRosenwasser DanielRosenwasser mentioned this pull request Nov 30, 2018
Merged
@DanielRosenwasser DanielRosenwasser merged commit 01f77f7 into microsoft:master Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser Awaiting requested review from DanielRosenwasser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weswigham @DanielRosenwasser