Store exported names locally #2948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| setters:[ | ||
| function (_bar_1) { | ||
| for (var n in _bar_1) | ||
| if (!exportedNames_1.hasOwnProperty(n)) exports_1(n, _bar_1[n]); |
There was a problem hiding this comment.
export var x;
export * from "A"; //y
export * from "B"; //y
There was a problem hiding this comment.
per spec (15.2.1.16.3 ResolveExport( exportName, resolveSet, exportStarSet ) Concrete Method) if some name can be resolved from more than one star export the result is ambiguous, When re-exports and imports are resolved during module instantiation it is a syntax error to have ambiguous resolution (per 15.2.1.16.4 ModuleDeclarationInstantiation( ) Concrete Method).Since this situation is an error (not sure if ES6 module loader treats it as such) I think it is ok to keep this aspect implementation specific.
| emitNodeWithoutSourceMap(node); | ||
| } | ||
| else if (node.flags & NodeFlags.Default) { | ||
| write("default"); |
There was a problem hiding this comment.
may be should filter out default all the time.
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate a local object that will store names of local/indirectly exported entries. This object is later used to check that names from star exports don't shadow local/indirectly exported names.