Fix crash in signatureHelp #29534
Merged
Fix crash in signatureHelp #29534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| if (ts.sys.tryEnableSourceMapsForHost && /^development$/i.test(ts.sys.getEnvironmentVariable("NODE_ENV"))) { | ||
| ts.sys.tryEnableSourceMapsForHost(); | ||
| } |
There was a problem hiding this comment.
While at it can you please add enabling debug info on nodes/sourcefiles/symbols as well. Thanks for doing this.
if (ts.Debug.isDebugging) {
ts.Debug.enableDebugInfo();
}
sheetalkamat
approved these changes
Jan 22, 2019
weswigham
approved these changes
Jan 22, 2019
|
This has also been merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a crash in signature help. When we pass
trueforisManuallyInvokedwhen callinggetContainingArgumentInfo, we were shortcutting theisSourceFilecheck. Both therangeContainsRangecheck and the following call togetImmediatelyContainingArgumentOrContextualParameterInforequire a node with a validparent, and aSourceFiledoes not have aparent.Fixes #29355