Skip to content

Conversation

Kingwl
Copy link
Contributor

@Kingwl Kingwl commented Feb 13, 2019

Fixes #29891

Copy link
Member

@weswigham weswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does ContainsSeparator need to be public if , eg, ExtendedUnicodeEscape isn't?

@Kingwl
Copy link
Contributor Author

Kingwl commented Feb 21, 2019

@weswigham
Actually, i'm not sure that which Flag should we expose, Could you give some suggestion?

@weswigham weswigham merged commit 592396d into microsoft:master Feb 21, 2019
@Kingwl Kingwl deleted the numeric_factory branch February 21, 2019 23:52
@OzelotVanilla
Copy link

Sorry for replying this already closed pull request. I am writing a transpiler using TS Compiler API, and I come from web searching. I would like to notice that in at least typescript@5.7.2, numericLiteralFlags does not exist in interface NumericLiteral (in the file typescript.d.ts). I want to ask if it is done on purpose, or ?

Currently the generated typescript.d.ts files looks like this (should we have numericLiteralFlags being defined here ?):

    interface NumericLiteral extends LiteralExpression, Declaration {
        readonly kind: SyntaxKind.NumericLiteral;
    }

I searched the repository and I cannot find where the NumericLiteral is defined. Sorry that I cannot create a pull request for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants