Never overwrite resolved types of symbols #29959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahejlsberg
requested review from
RyanCavanaugh,
weswigham and
DanielRosenwasser
RyanCavanaugh
approved these changes
Feb 19, 2019
weswigham
approved these changes
Feb 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symbol type resolution is supposed to be idempotent, but in certain recursive scenarios we would overwrite the resolved type of a symbol with another (possibly different) type. That could cause quick info to display different types depending on the order in which types are examined. With this PR we ensure that the
typeproperty ofSymbolLinksis stillundefinedbefore assigning to it.Fixes #27927.