emit input non .ts files as separate files when 'allowNonTsExtensions' a... #3029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' and 'separateCompilation' flags are specified (used in 'transpile' related scenarios)
| if ((isExternalModule(sourceFile) || !compilerOptions.out)) { | ||
| // 1. in-browser single file compilation scenario | ||
| // 2. non .js file | ||
| return (compilerOptions.separateCompilation && compilerOptions.allowNonTsExtensions) || |
There was a problem hiding this comment.
why not just compilerOptions.allowNonTsExtensions?
There was a problem hiding this comment.
wanted to be sure that this is enabled only for in-memory transpile scenario where we set these two properties
|
approved offline by @mhegazy |
vladima
added a commit
that referenced
this pull request
May 5, 2015
emit input non .ts files as separate files when 'allowNonTsExtensions' a...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...nd 'separateCompilation' flags are specified (used in 'transpile' related scenarios)
This PR forces emit for in-browser transpile scenarios when .js es6 file is converted to downlevel