Skip to content

Conversation

sheetalkamat
Copy link
Member

Fixes #30356

@sheetalkamat sheetalkamat requested review from RyanCavanaugh, rbuckton, sandersn and weswigham and removed request for RyanCavanaugh and rbuckton March 13, 2019 18:28
@RyanCavanaugh
Copy link
Member

What's the diff other than the move?

@sheetalkamat
Copy link
Member Author

To match what we do in getOwnOutputFileNames with sourceFile, eg. When file extension is JSON ignore everything else except it js output (that too only if its not same as input file name)
https://github.com/Microsoft/TypeScript/pull/30374/files#diff-20a9fa4d3e9d09f60c275a3dda245867R177

@sheetalkamat sheetalkamat merged commit e42f37f into master Mar 13, 2019
@sheetalkamat sheetalkamat deleted the jsonSourceFile branch March 13, 2019 22:01
@weswigham
Copy link
Member

@sheetalkamat is there something non-deterministic in this PR? We're failing on random versions of node with

        unittests:: tsbuild:: with resolveJsonModule option
           with resolveJsonModule and sourceMap:
     AssertionError: Diagnostic arrays did not match: expected [ Array(2) ] to deeply equal [ Array(2) ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants