Use const contexts and tuple mapped types to simplify some explicitly elucidated types #30654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… elucidated types
weswigham
commented
Mar 30, 2019
src/compiler/types.ts
Outdated
| UnionToIntersection<{ | ||
| [K in keyof NonNullable<T["args"]>]: PragmaArgTypeOptional< | ||
| NonNullable<T["args"]>[K], | ||
| NonNullable<T["args"]>[K] extends {name: infer TName} ? TName extends string ? TName : never : never |
There was a problem hiding this comment.
This should just be
Suggested change
| NonNullable<T["args"]>[K] extends {name: infer TName} ? TName extends string ? TName : never : never | |
| NonNullable<T["args"]>[K]["name"] |
but we get the constraint of NonNullable<T["args"]>[K] wrong and error on that, it seems. I'm sure more future improvements will render this fixed and simplifiable, too.
sandersn
approved these changes
Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small cleanup that uses some newer language features to delete ~10 lines of code form
types.ts.