Skip to content

Assert ranges exist when looped over in fourslash #32012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2019
Merged

Assert ranges exist when looped over in fourslash #32012

merged 1 commit into from
Jun 21, 2019

Conversation

weswigham
Copy link
Member

Fixes #6120

@DanielRosenwasser
Copy link
Member

I think this is fine within the fourslash harness, but does this work with the tests which just use a for-loop to iterate over ranges?

@weswigham
Copy link
Member Author

but does this work with the tests which just use a for-loop to iterate over ranges?

You should be using verify.forEachRange if you do that AFAIK, so yes. If you grab the list of ranges otherwise, then no.

@weswigham weswigham merged commit fe2b9e9 into microsoft:master Jun 21, 2019
@weswigham weswigham deleted the add-fourslash-asserts branch June 21, 2019 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheetalkamat sheetalkamat sheetalkamat approved these changes

@sandersn sandersn Awaiting requested review from sandersn

@DanielRosenwasser DanielRosenwasser Awaiting requested review from DanielRosenwasser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fourslash tests which loop over every range should assert the presence of a non-empty list of ranges
3 participants
@weswigham @DanielRosenwasser @sheetalkamat