Rework declaration emit visibility calculation for namespaces #32156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -287,4 +287,5 @@ declare module m { | |||
| foo114: m2.public2; | |||
| foo115: m2.public2; | |||
| } | |||
| export {}; | |||
There was a problem hiding this comment.
Why do you need this here? exported class above is enough to make things public and private ?
There was a problem hiding this comment.
Not in a declaration file (or other ambient context) it's not. 😄 Just like at the top level, unless there's an export declaration or export assignment, all the things are implicitly exported, export modifier or no.
|
F. Need to rerun tests with |
sheetalkamat
approved these changes
Jun 28, 2019
sheetalkamat
added a commit
that referenced
this pull request
Jul 16, 2019
… after LKG Its not detected currently is because LKG doesnt have #32156
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that it emits
export {};to retain privates, just like the top-level does.Fixes #31487