Update __awaiter to be more spec compliant #32462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @weswigham, @RyanCavanaugh (since I can't add reviewers) |
weswigham
approved these changes
Jul 22, 2019
|
Possibly, though we might be up to the whims of future spec changes and newer versions of node/v8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
__awaiterhelper to be closer to the spec.new Promise(resolve => resolve(value))takes one turn more thanPromise.resolve(value). However, we do not (and cannot) rely on the existence ofPromise.resolvedown-level, so we do the next best thing and testvalue instanceof P(wherePmay be a custom Promise-like constructor.A similar change will need to be made to tslib, and is forthcoming.
Fixes #31552.