🤖 User test baselines have changed #33635
Conversation
typescript-bot
force-pushed
the
user-update-Microsoft-20190805
branch
from
709c4b0 to
eb84199
Compare
| Standard output: | ||
|
|
||
| > xterm@X.X.X build /xtermjs | ||
| > tsc -b ./tsconfig.all.json | ||
| src/browser/Clipboard.ts(85,5): error TS2322: Type 'null' is not assignable to type 'string'. |
There was a problem hiding this comment.
These are due to a DOM update that removed null as a valid type for some members of CSSStyleDeclaration.
| @@ -8,7 +8,7 @@ node_modules/bcryptjs/src/bcrypt.js(150,5): error TS2322: Type 'string | undefin | |||
| Type 'undefined' is not assignable to type 'string'. | |||
| node_modules/bcryptjs/src/bcrypt.js(160,14): error TS2366: Function lacks ending return statement and return type does not include 'undefined'. | |||
| node_modules/bcryptjs/src/bcrypt.js(238,14): error TS2366: Function lacks ending return statement and return type does not include 'undefined'. | |||
| node_modules/bcryptjs/src/bcrypt/impl.js(516,22): error TS2345: Argument of type 'Int32List' is not assignable to parameter of type 'number[]'. | |||
| node_modules/bcryptjs/src/bcrypt/impl.js(516,22): error TS2345: Argument of type 'number[] | Int32Array' is not assignable to parameter of type 'number[]'. | |||
There was a problem hiding this comment.
Interesting - we lost an alias here. @sandersn do you know if the type Int32List = Int32Array | GLint[]; alias was removed from dom (and inlined at usages)? That's probably a breaking change.
| Type '{ ExpandRetainersComplete: symbol; }' is missing the following properties from type '{ ContentShown: symbol; SortingComplete: symbol; }': ContentShown, SortingComplete | ||
| node_modules/chrome-devtools-frontend/front_end/profiler/HeapSnapshotDataGrids.js(603,43): error TS2417: Class static side 'typeof HeapSnapshotRetainmentDataGrid' incorrectly extends base class static side 'typeof HeapSnapshotContainmentDataGrid'. | ||
| Types of property 'Events' are incompatible. | ||
| Type '{ ExpandRetainersComplete: symbol; }' is not assignable to type '{ ContentShown: symbol; SortingComplete: symbol; }'. |
There was a problem hiding this comment.
Static side inheritance errors brought on by better usage of getMergeSymbol in the js declaration emitter PR. We should have always been issuing these.
| lib/WebSocketTransport.js(32,72): error TS2345: Argument of type 'WebSocket' is not assignable to parameter of type 'WebSocket'. | ||
| Property 'dispatchEvent' is missing in type 'WebSocket' but required in type 'WebSocket'. | ||
| lib/WebSocketTransport.js(32,72): error TS2345: Argument of type 'import("/puppeteer/puppeteer/node_modules/@types/ws/index")' is not assignable to parameter of type 'WebSocket'. | ||
| Property 'dispatchEvent' is missing in type 'import("/puppeteer/puppeteer/node_modules/@types/ws/index")' but required in type 'WebSocket'. |
There was a problem hiding this comment.
It looks more strange, but now you know that the global WebSocket and the WebSocket referred to on the LHS differ. I'm pretty sure this is just due to some better prioritization in symbols during symbol name lookup (also actually recognizing that a exports = WebSocket means the module symbol is a viable reference to the WebSocket).
|
cc @DanielRosenwasser at least as-is, 3.7 is going to be breaky for |
|
Yes please keep me in the loop! |
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @weswigham @sandersn @RyanCavanaugh