Add build target for packaging tsserver as a library #3542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @weswigham, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
| @@ -1360,10 +1360,11 @@ module ts.server { | |||
| } | |||
| } | |||
|
|
|||
| static fromString(script: string) { | |||
| static fromString(host: System, script: string) { | |||
| var svc = new ScriptVersionCache(); | |||
|
thanks. looks good. 2 small comments and we are ready to go. |
|
Got it. |
|
thanks! |
mhegazy
added a commit
that referenced
this pull request
Jun 18, 2015
Add build target for packaging tsserver as a library
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion on #3513. this is the first half of the proposed changes - only those required to package the service as a library, combined with feedback from the same PR.