Add asserts to narrow down position issue #35742
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Visual Studio, we're seeing hundreds of hits where a location returned in
semanticDiagnosticsSync
has either a non-positive line or non-positive offset.To narrow down the investigation, I'm adding these asserts so that we have just a little more context to help the investigation (that is, I think it would be helpful to know whether the bad value is null/undefined, 0, or negative).