Go to definition for type predicate #3611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -11925,6 +11925,10 @@ namespace ts { | |||
| return resolveEntityName(<EntityName>entityName, meaning); | |||
| } | |||
|
|
|||
| if (entityName.parent.kind === SyntaxKind.TypePredicate) { | |||
| return resolveEntityName(<Identifier>entityName, /* meanings */ SymbolFlags.FunctionScopedVariable); | |||
There was a problem hiding this comment.
nit: We usually don't put space around the name for the comment
There was a problem hiding this comment.
thanks, I also noticed that the parameter name is without plural. Fixed now.
|
👍 |
|
thanks! |
mhegazy
added a commit
that referenced
this pull request
Jun 24, 2015
Go to definition for type predicate
This was referenced Jun 25, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3600.